Summary: | It should be possible to send all JSC debug logging to a file | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dglazkov, rakuco, webkit.review.bot | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Filip Pizlo
2012-02-11 11:13:58 PST
Created attachment 126639 [details]
the patch
Attachment 126639 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/wtf/DebugLogging.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:608: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:610: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:625: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:626: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:627: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:628: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:629: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:630: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/bytecode/CodeBlock.cpp:1396: More than one command on the same line [whitespace/newline] [4]
Total errors found: 10 in 52 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 126639 [details] the patch Attachment 126639 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11505202 Comment on attachment 126639 [details] the patch Attachment 126639 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11509162 Comment on attachment 126639 [details] the patch Attachment 126639 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11509161 Created attachment 126640 [details]
the patch
Attachment 126640 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/wtf/DebugLogging.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:608: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:610: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:625: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:626: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:627: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:628: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:629: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:630: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/bytecode/CodeBlock.cpp:1396: More than one command on the same line [whitespace/newline] [4]
Total errors found: 10 in 52 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 126644 [details]
the patch
- Fixing build
- As per chat with Sam, changed the name from "debug logging" to "data log". "debugPrintf" becomes "dataLog", "debugFile" becomes "dataFile", and "DebugLogging.h" becomes "DataLog.h".
Going to wait on EWS for this patch, since it's big and juicy. Created attachment 126649 [details]
the patch
Rebased patch, putting up for EWS.
Attachment 126649 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/profiler/ProfileNode.cpp:35: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:608: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:610: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:625: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:626: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:627: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:628: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:629: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:630: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/bytecode/CodeBlock.cpp:1396: More than one command on the same line [whitespace/newline] [4]
Source/JavaScriptCore/wtf/DataLog.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4]
Total errors found: 11 in 53 files
If any of these errors are false positives, please file a bug against check-webkit-style.
OK, it looks like the bots are as green as they're going to get. Landed in http://trac.webkit.org/changeset/107499 |