Bug 78418

Summary:

It should be possible to send all JSC debug logging to a file

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, rakuco, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	webkit.review.bot: commit-queue-
the patch	none
the patch	sam: review+
the patch	none

Filip Pizlo

Reported 2012-02-11 11:13:58 PST

Patch forthcoming.

Attachments
the patch (210.57 KB, patch) 2012-02-11 11:28 PST, Filip Pizlo	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
the patch (210.67 KB, patch) 2012-02-11 12:24 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (209.56 KB, patch) 2012-02-11 13:45 PST, Filip Pizlo	sam: review+	Details Formatted Diff Diff
the patch (209.11 KB, patch) 2012-02-11 14:48 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2012-02-11 11:28:54 PST

Created attachment 126639 [details] the patch

WebKit Review Bot

Comment 2 2012-02-11 11:34:56 PST

Attachment 126639 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/DebugLogging.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:608: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:610: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:625: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:626: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:627: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:628: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:629: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:630: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/bytecode/CodeBlock.cpp:1396: More than one command on the same line [whitespace/newline] [4] Total errors found: 10 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 3 2012-02-11 11:55:07 PST

Comment on attachment 126639 [details] the patch Attachment 126639 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11505202

Early Warning System Bot

Comment 4 2012-02-11 11:55:43 PST

Comment on attachment 126639 [details] the patch Attachment 126639 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11509162

Gyuyoung Kim

Comment 5 2012-02-11 11:58:26 PST

Comment on attachment 126639 [details] the patch Attachment 126639 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11509161

Filip Pizlo

Comment 6 2012-02-11 12:24:06 PST

Created attachment 126640 [details] the patch

WebKit Review Bot

Comment 7 2012-02-11 12:27:15 PST

Attachment 126640 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/DebugLogging.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:608: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:610: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:625: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:626: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:627: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:628: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:629: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:630: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/bytecode/CodeBlock.cpp:1396: More than one command on the same line [whitespace/newline] [4] Total errors found: 10 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 8 2012-02-11 13:45:38 PST

Created attachment 126644 [details] the patch - Fixing build - As per chat with Sam, changed the name from "debug logging" to "data log". "debugPrintf" becomes "dataLog", "debugFile" becomes "dataFile", and "DebugLogging.h" becomes "DataLog.h".

Filip Pizlo

Comment 9 2012-02-11 13:49:27 PST

Going to wait on EWS for this patch, since it's big and juicy.

Filip Pizlo

Comment 10 2012-02-11 14:48:11 PST

Created attachment 126649 [details] the patch Rebased patch, putting up for EWS.

WebKit Review Bot

Comment 11 2012-02-11 14:52:22 PST

Attachment 126649 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/profiler/ProfileNode.cpp:35: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:608: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:610: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:625: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:626: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:627: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:628: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:629: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/interpreter/Interpreter.cpp:630: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/bytecode/CodeBlock.cpp:1396: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/DataLog.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4] Total errors found: 11 in 53 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 12 2012-02-11 19:20:17 PST

OK, it looks like the bots are as green as they're going to get.

Filip Pizlo

Comment 13 2012-02-11 19:22:17 PST

Landed in http://trac.webkit.org/changeset/107499

Filip Pizlo

Comment 14 2012-02-11 19:22:47 PST

<rdar://problem/10849720>

Note You need to log in before you can comment on or make changes to this bug.