Summary: | [chromium] compositing/rubberbanding tests failing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
Component: | Tools / Tests | Assignee: | asvitkine | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | asvitkine, jamesr, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tony Chang
2012-02-10 12:09:10 PST
James can you take a look? I'm going to mark the tests as failing for now. Looking at the flaky runs of green/non-green results, the non-green results have tiny pixel differences in the rubber band gradients only. Is that a known cause of flakyness with the compositing path? It seems the non-compositing rubber-banding tests don't have this flakyness in the gradients. And then there's the more recent regression that just causes them to fail all the time due to not pattern/gradient area being drawn at all... Pretty sure it's the mock scrollbars change. Rubber-band overhang painting is done by ScrollbarThemeChromiumMac.mm, while the mock scrollbar changes replaces this by ScrollbarThemeMock. Created attachment 127389 [details]
Patch
Comment on attachment 127389 [details]
Patch
If you want these specific tests to not use mock scrollbars, then just call window.internals.settings.setMockScrollbarsEnabled(false) in the tests
Created attachment 127415 [details]
Patch
Comment on attachment 127415 [details]
Patch
New patch that just changes the tests to disable mock scrollbars.
Comment on attachment 127415 [details]
Patch
r=me
Comment on attachment 127415 [details] Patch Clearing flags on attachment: 127415 Committed r108000: <http://trac.webkit.org/changeset/108000> All reviewed patches have been landed. Closing bug. |