Bug 78359 – [chromium] Remove obsolete zoom animation pathway.

• Component: New Bugs
• Status: RESOLVED FIXED

[W. James MacLean]

[chromium] Remove obsolete zoom animation pathway.

[W. James MacLean]

Created attachment 126514 [details]
Patch

[W. James MacLean]

Removes dead code from the now obsolete pathway for zoom animation. Includes removal of unused functions from testing/Internals*.

[WebKit Review Bot]

Comment on attachment 126514 [details]
Patch

Attachment 126514 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11473690

New failing tests:
fast/dom/Range/scale-page-client-rects.html
fast/events/page-scaled-mouse-click-iframe.html
fast/frames/iframe-double-scale-contents.html
compositing/geometry/fixed-position-transform-composited-page-scale.html
fast/dom/window-inner-size-scaling.html
http/tests/inspector/inspect-element.html
fast/dom/Element/scale-page-bounding-client-rect.html
fast/events/scale-and-scroll-window.html
compositing/geometry/fixed-position-iframe-composited-page-scale.html
fast/events/scroll-in-scaled-page-with-overflow-hidden.html
fast/events/page-scaled-mouse-click.html
fast/events/scale-and-scroll-iframe-body.html
fast/dom/iframe-inner-size-scaling.html
compositing/scaling/tiled-layer-recursion.html
fast/repaint/background-scaling.html
compositing/geometry/fixed-position-composited-page-scale.html
fast/events/scale-and-scroll-body.html
accessibility/aria-describedby-on-input.html
fast/events/touch/page-scaled-touch-gesture-click.html
fast/events/scale-and-scroll-iframe-window.html
fast/frames/frame-set-scaling-hit.html
compositing/geometry/fixed-position-iframe-composited-page-scale-down.html
fast/frames/frame-set-rotation-hit.html
compositing/geometry/fixed-position-composited-page-scale-down.html
fast/dom/Element/scale-page-client-rects.html
compositing/geometry/fixed-position-transform-composited-page-scale-down.html
fast/dom/Range/scale-page-bounding-client-rect.html
fast/repaint/scale-page-shrink.html

[W. James MacLean]

(In reply to comment #3)
> (From update of attachment 126514 [details])
> Attachment 126514 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/11473690
> 
> New failing tests:
> fast/dom/Range/scale-page-client-rects.html
> fast/events/page-scaled-mouse-click-iframe.html
> fast/frames/iframe-double-scale-contents.html
> compositing/geometry/fixed-position-transform-composited-page-scale.html
> fast/dom/window-inner-size-scaling.html
> http/tests/inspector/inspect-element.html
> fast/dom/Element/scale-page-bounding-client-rect.html
> fast/events/scale-and-scroll-window.html
> compositing/geometry/fixed-position-iframe-composited-page-scale.html
> fast/events/scroll-in-scaled-page-with-overflow-hidden.html
> fast/events/page-scaled-mouse-click.html
> fast/events/scale-and-scroll-iframe-body.html
> fast/dom/iframe-inner-size-scaling.html
> compositing/scaling/tiled-layer-recursion.html
> fast/repaint/background-scaling.html
> compositing/geometry/fixed-position-composited-page-scale.html
> fast/events/scale-and-scroll-body.html
> accessibility/aria-describedby-on-input.html
> fast/events/touch/page-scaled-touch-gesture-click.html
> fast/events/scale-and-scroll-iframe-window.html
> fast/frames/frame-set-scaling-hit.html
> compositing/geometry/fixed-position-iframe-composited-page-scale-down.html
> fast/frames/frame-set-rotation-hit.html
> compositing/geometry/fixed-position-composited-page-scale-down.html
> fast/dom/Element/scale-page-client-rects.html
> compositing/geometry/fixed-position-transform-composited-page-scale-down.html
> fast/dom/Range/scale-page-bounding-client-rect.html
> fast/repaint/scale-page-shrink.html

The removed pathway should have been inactive for quite a long time, so I'm not sure (could be wrong) that these failures are related to this patch. I'm getting massive failures when running the layout tests on ToT without this patch.

[W. James MacLean]

Created attachment 126580 [details]
Patch

[W. James MacLean]

I was over-zealous and removed something that lead to the test breakage. This patch should fix that.

[James Robinson]

I like this idea a lot.  It looks like you've hit conflicts with some of Anders' cleanups in ScrollableArea, mind resolving that and re-uploading?

[Anders Carlsson]

This is great! I was just wondering the other day why the scrollable area needed to know about zoom transforms :) Glad that it's obsolete.

[W. James MacLean]

(In reply to comment #7)
> I like this idea a lot.  It looks like you've hit conflicts with some of Anders' cleanups in ScrollableArea, mind resolving that and re-uploading?

NP, will do so tomorrow at some point.

[W. James MacLean]

Created attachment 126760 [details]
Patch

[James Robinson]

Comment on attachment 126760 [details]
Patch

R=me.  Please fix the mac build failure before landing:

/var/folders/db/z_22lpwn061cd362c11ktng40000gn/C/com.apple.Xcode.501/SharedPrecompiledHeaders/WebKit2Prefix-dklphnaxgqneptaesbgjjhyuylhp/WebKit2Prefix.h -c /Volumes/Data/WebKit/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp -o /Volumes/Data/WebKit/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/BuiltInPDFView.o
In file included from /Volumes/Data/WebKit/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp:27:
/Volumes/Data/WebKit/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h:143: error: 'ZoomAnimationState' has not been declared

I think all you need to do is delete the override

[W. James MacLean]

Created attachment 126793 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 126793 [details]
Patch for landing

Clearing flags on attachment: 126793

Committed r107665: <http://trac.webkit.org/changeset/107665>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.