Bug 78354

Summary: Rename [JSCustomPrototypeDefineOwnProperty] to [JSCustomDefineOwnPropertyOnPrototype]
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77393    
Attachments:
Description Flags
Patch
none
rebased patch for commit none

Kentaro Hara
Reported 2012-02-10 05:25:38 PST
We can rename [JSCustomPrototypeDefineOwnProperty] to [JSCustomDefineOwnPropertyOnPrototype], for naming consistency with [JSCustomDefineOwnProperty] and [JSCustomNamedGetterOnPrototype].
Attachments
Patch (2.75 KB, patch)
2012-02-10 05:27 PST, Kentaro Hara
no flags
rebased patch for commit (2.68 KB, patch)
2012-02-12 01:06 PST, Kentaro Hara
no flags
Kentaro Hara
Comment 1 2012-02-10 05:27:51 PST
WebKit Review Bot
Comment 2 2012-02-10 13:49:15 PST
Comment on attachment 126505 [details] Patch Rejecting attachment 126505 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: git/webkit-commit-queue/Source/WebKit/chromium/ui --revision 121421 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 45>At revision 121421. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/11480805
Kentaro Hara
Comment 3 2012-02-12 01:06:49 PST
Created attachment 126672 [details] rebased patch for commit
WebKit Review Bot
Comment 4 2012-02-12 02:41:45 PST
Comment on attachment 126672 [details] rebased patch for commit Clearing flags on attachment: 126672 Committed r107506: <http://trac.webkit.org/changeset/107506>
Note You need to log in before you can comment on or make changes to this bug.