Bug 78335

Summary: Remove [ConvertScriptString] from FileReaderSync.idl
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, ericu, japhet, jianli, ojan, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77393    
Attachments:
Description Flags
Patch none

Description Kentaro Hara 2012-02-10 01:12:06 PST 
[ConvertScriptString] is used by FileReaderSync.idl only. The difference between [ConvertScriptString] and [TreatReturnedNullStringAs=Null] is whether the returned string is generated by jsString() or jsOwnedString() in JSC (No difference in V8).

I am not sure why (only) FileReaderSync.idl requires jsOwnedString(). If it is not necessary, I would like to replace [ConvertScriptString] with [TreatReturnedNullStringAs=Null], and remove [ConvertScriptString] completely from code generators.

Any advice?
Comment 1 Kentaro Hara 2012-02-12 18:00:56 PST 
The spec says that FileReadSync should throw NOT_FOUND_ERR if a given blob is invalid: http://www.w3.org/TR/FileAPI/#FileReaderSync

By throwing NOT_FOUND_ERR if a given blob is invalid, we can remove [ConvertScriptString] from FileReadSync.idl.
Comment 2 Kentaro Hara 2012-02-12 18:16:50 PST 
Created attachment 126699 [details]
Patch
Comment 3 Eric Seidel (no email) 2012-02-16 13:15:35 PST 
Comment on attachment 126699 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2012-02-16 16:10:40 PST 
Comment on attachment 126699 [details]
Patch

Clearing flags on attachment: 126699

Committed r107994: <http://trac.webkit.org/changeset/107994>
Comment 5 WebKit Review Bot 2012-02-16 16:10:45 PST 
All reviewed patches have been landed.  Closing bug.