Summary: | Rename classes defined in ContentInclusionSelector to more suitable names which match the spec | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||||
Component: | DOM | Assignee: | Hayato Ito <hayato> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, dominicc, morrita, rakuco, rolandsteiner, shinyak, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 63606 | ||||||||
Attachments: |
|
Description
Hayato Ito
2012-02-10 01:11:12 PST
How about this? ContentInclusionSelector -> HostChildNodesSelector ShadowInclusionSet -> HostChildNodesSelectionSet ShadowInclusionList -> HostChildNodesSelectionList ShadowInclusion -> HostChildNodesSelection If there is no objection, let me rename. "Nodes" looks redundant, especially inside a noun? I guess it's ok to rename it HTMLContent something, considering it's for <content>. and they are under html/shadow. Okay. Let me rename as follows: ContentInclusionSelector -> HTMLContentSelector ShadowInclusionSet -> HTMLContentSelectionSet ShadowInclusionList -> HTMLContentSelectionList ShadowInclusion -> HTMLContentSelection I also rename member functions and variables to match the names. (In reply to comment #2) > "Nodes" looks redundant, especially inside a noun? I guess it's ok to rename it HTMLContent something, considering it's for <content>. and they are under html/shadow. Created attachment 126488 [details]
rename
Created attachment 126493 [details]
update.
Most renaming is done. The patch is reedy for review. Follow-up patch will do remaining renaming, such as renaming window.Internals binding. Morrita-san, could you take a look? Comment on attachment 126493 [details] update. Clearing flags on attachment: 126493 Committed r107558: <http://trac.webkit.org/changeset/107558> All reviewed patches have been landed. Closing bug. |