Bug 78325

Summary: CSS3 calc: update font-size test to use pre/post js
Product: WebKit Reporter: Mike Lawther <mikelawther>
Component: New BugsAssignee: Mike Lawther <mikelawther>
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 16662    
Description Flags
Patch none

Description Mike Lawther 2012-02-09 21:30:48 PST
CSS3 calc: update font-size test to use pre/post js
Comment 1 Mike Lawther 2012-02-09 21:31:27 PST
Created attachment 126448 [details]
Comment 2 Ojan Vafai 2012-02-10 10:30:34 PST
Comment on attachment 126448 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=126448&action=review

> LayoutTests/css3/calc/font-size.html:22
> +    shouldBeEqualToString('getComputedStyle(document.getElementById("' + spans[i].id + '"), null).fontSize', getComputedStyle(document.getElementById("control"), null).fontSize);

In future tests, you could make this more readable by creating a helper function: 
function fontSize(id) {
    return getComputedStyle(document.getElementById("' + id + '"), null).fontSize;
Comment 3 WebKit Review Bot 2012-02-10 12:08:13 PST
Comment on attachment 126448 [details]

Clearing flags on attachment: 126448

Committed r107425: <http://trac.webkit.org/changeset/107425>
Comment 4 WebKit Review Bot 2012-02-10 12:08:17 PST
All reviewed patches have been landed.  Closing bug.