Summary: | CSS3 calc: update font-size test to use pre/post js | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mike Lawther <mikelawther> | ||||
Component: | New Bugs | Assignee: | Mike Lawther <mikelawther> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 16662 | ||||||
Attachments: |
|
Description
Mike Lawther
2012-02-09 21:30:48 PST
Created attachment 126448 [details]
Patch
Comment on attachment 126448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126448&action=review > LayoutTests/css3/calc/font-size.html:22 > + shouldBeEqualToString('getComputedStyle(document.getElementById("' + spans[i].id + '"), null).fontSize', getComputedStyle(document.getElementById("control"), null).fontSize); In future tests, you could make this more readable by creating a helper function: function fontSize(id) { return getComputedStyle(document.getElementById("' + id + '"), null).fontSize; } Comment on attachment 126448 [details] Patch Clearing flags on attachment: 126448 Committed r107425: <http://trac.webkit.org/changeset/107425> All reviewed patches have been landed. Closing bug. |