| Summary: | The JS Parser scope object needs a VectorTrait specialization | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||
| Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ggaren | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Oliver Hunt
2012-02-09 18:13:31 PST
Created attachment 126421 [details]
Patch
Comment on attachment 126421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126421&action=review > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:418 > + if (1) { Oooops, you probably want to remove that. > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1227 > + if (JSActivation* activation = jsDynamicCast<JSActivation*>(currentVariableObject)) Will this if be optimized out in release builds? – I'd prefer to see: ASSERT(!jsDynamicCast<JSActivation*>(currentVariableObject) || jsDynamicCast<JSActivation*>(currentVariableObject)->isValidScopedLookup(entry.getIndex())); Committed r107338: <http://trac.webkit.org/changeset/107338> |