Bug 78308

Summary: The JS Parser scope object needs a VectorTrait specialization
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch barraclough: review+

Oliver Hunt
Reported 2012-02-09 18:13:31 PST
The JS Parser scope object needs a VectorTrait specialization
Attachments
Patch (5.95 KB, patch)
2012-02-09 18:16 PST, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2012-02-09 18:16:22 PST
Created attachment 126421 [details] Patch
Gavin Barraclough
Comment 2 2012-02-09 18:20:13 PST
Comment on attachment 126421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126421&action=review > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:418 > + if (1) { Oooops, you probably want to remove that. > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1227 > + if (JSActivation* activation = jsDynamicCast<JSActivation*>(currentVariableObject)) Will this if be optimized out in release builds? – I'd prefer to see: ASSERT(!jsDynamicCast<JSActivation*>(currentVariableObject) || jsDynamicCast<JSActivation*>(currentVariableObject)->isValidScopedLookup(entry.getIndex()));
Oliver Hunt
Comment 3 2012-02-09 18:26:34 PST
Committed r107338: <http://trac.webkit.org/changeset/107338>
Geoffrey Garen
Comment 4 2012-02-10 10:37:04 PST
<rdar://problem/10734517>
Note You need to log in before you can comment on or make changes to this bug.