| Summary: | Web Inspector: Prevent attaching when inspecting the Web Inspector | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Timothy Hatcher <timothy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Timothy Hatcher
2012-02-09 17:54:48 PST
Created attachment 126414 [details]
Proposed Change
Comment on attachment 126414 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=126414&action=review > Source/WebKit2/UIProcess/WebInspectorProxy.cpp:272 > + unsigned maximumAttachedHeight = inspectedPageHeight * 3 / 4; Is it worth it to use a constant for 3/4 like WebCore? It seems like we could just put it in WebInspectorProxy.h next to minimumAttachedHeight. Comment on attachment 126414 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=126414&action=review >> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:272 >> + unsigned maximumAttachedHeight = inspectedPageHeight * 3 / 4; > > Is it worth it to use a constant for 3/4 like WebCore? It seems like we could just put it in WebInspectorProxy.h next to minimumAttachedHeight. IIRC, we can't use "static float" in class headers on Windows, so that is why we never did that. Comment on attachment 126414 [details] Proposed Change Clearing flags on attachment: 126414 Committed r107362: <http://trac.webkit.org/changeset/107362> All reviewed patches have been landed. Closing bug. |