|Summary:||Rename compare_text and compare_audio to make it clear that they're !=|
|Product:||WebKit||Reporter:||Eric Seidel (no email) <eric>|
|Component:||New Bugs||Assignee:||Eric Seidel (no email) <eric>|
|Severity:||Normal||CC:||abarth, ojan, webkit.review.bot|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Eric Seidel (no email) 2012-02-09 17:54:14 PST
Rename compare_text and compare_audio to make it clear that they're !=
Comment 2 WebKit Review Bot 2012-02-09 22:18:28 PST
Comment on attachment 126415 [details] Patch Clearing flags on attachment: 126415 Committed r107361: <http://trac.webkit.org/changeset/107361>
Comment 3 WebKit Review Bot 2012-02-09 22:18:33 PST
All reviewed patches have been landed. Closing bug.
Comment 4 Dirk Pranke 2012-02-19 11:58:27 PST
Comment on attachment 126415 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126415&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:300 > + # FIXME: Seems we should get this from the Port's Driver class. The reason this is here as a separate file is that there is no direct route to a Driver object; you have to actually create one; when this was first written, I thought creating a driver might actually launch a process and hence be a heavyweight operation. Things haven't turned out that way, so we could probably fix this in a straightforward manner.