Bug 78271

Summary:

run-perf-tests should have an option to pause before running tests so we can attach Instruments

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ojan, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+

Description Adam Barth 2012-02-09 12:43:55 PST

run-perf-tests should have an option to pause before running tests so we can attach Instruments

Comment 1 Adam Barth 2012-02-09 12:44:36 PST

Created attachment 126351 [details]
Patch

Comment 2 Ryosuke Niwa 2012-02-09 12:47:08 PST

Comment on attachment 126351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126351&action=review

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:196
> +            self.assertEqual(stderr, "Ready to run test?\n")

It's strange that we use stderr for this

Comment 3 Adam Barth 2012-02-09 13:26:19 PST

Yeah, we didn't understand logging when we started webkitpy.

Comment 4 Adam Barth 2012-02-09 13:26:39 PST

Committed r107284: <http://trac.webkit.org/changeset/107284>