Bug 78254

Summary: Web Inspector: [refactoring] TimelineModel should not depend on TimelinePanel
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED INVALID    
Severity: Normal CC: apavlov, bburg, bweinstein, keishi, loislo, ossy, pfeldman, pmuellr, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Andrey Kosyakov
Reported 2012-02-09 10:58:07 PST
This breaks cyclical dependency between TimelineModel and TimelinePanel by introducing EventRecorded and EventsCleared events dispatched by the timeline model.
Attachments
Patch (7.52 KB, patch)
2012-02-09 23:31 PST, Andrey Kosyakov
yurys: review+
Andrey Kosyakov
Comment 1 2012-02-09 23:31:34 PST
Yury Semikhatsky
Comment 2 2012-02-10 00:03:24 PST
Comment on attachment 126463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126463&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:1527 > +WebInspector.TimelineModel.Events = { Please place this constant declarations right after the constructor.
Andrey Kosyakov
Comment 3 2012-02-10 00:06:28 PST
Csaba Osztrogonác
Comment 4 2012-02-10 01:02:49 PST
Note You need to log in before you can comment on or make changes to this bug.