Summary: | Web Inspector: [refactoring] TimelineModel should not depend on TimelinePanel | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Kosyakov <caseq> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Kosyakov <caseq> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | apavlov, bburg, bweinstein, keishi, loislo, ossy, pfeldman, pmuellr, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Andrey Kosyakov
2012-02-09 10:58:07 PST
Created attachment 126463 [details]
Patch
Comment on attachment 126463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126463&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:1527 > +WebInspector.TimelineModel.Events = { Please place this constant declarations right after the constructor. Committed r107373: <http://trac.webkit.org/changeset/107373> Reopen, because it made a test fail on Qt: (maybe on other ports too) http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r107376%20%2833552%29/inspector/timeline/timeline-receive-response-event-pretty-diff.html |