Bug 7824

Summary:

Push parts of form submission code down into Frame.cpp

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

WebKit Misc.

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
push parts of MacFrame into Frame, GraphicsContextMac into GraphicsContext	darin: review+
Same patch, updated after rename changes.	none
Better patch, with darin's suggested changes.	none
Better patch, now also moving all Frame members to FramePrivate	darin: review+

Eric Seidel (no email)

Reported 2006-03-17 01:44:11 PST

Push parts of form submission code down into Frame.cpp If this form submits, we'll know the patch works. :)

Attachments
push parts of MacFrame into Frame, GraphicsContextMac into GraphicsContext (70.32 KB, patch) 2006-03-18 00:53 PST, Eric Seidel (no email)	darin: review+	Details Formatted Diff Diff
Same patch, updated after rename changes. (62.06 KB, patch) 2006-03-19 21:08 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Better patch, with darin's suggested changes. (67.10 KB, patch) 2006-03-19 21:23 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Better patch, now also moving all Frame members to FramePrivate (70.69 KB, patch) 2006-03-19 21:35 PST, Eric Seidel (no email)	darin: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2006-03-18 00:53:47 PST

Created attachment 7145 [details] push parts of MacFrame into Frame, GraphicsContextMac into GraphicsContext 4th attempt to post this patch.

Darin Adler

Comment 2 2006-03-18 04:32:17 PST

Comment on attachment 7145 [details] push parts of MacFrame into Frame, GraphicsContextMac into GraphicsContext I'd think you could just rename drawFloatImage to drawImage. + ~GraphicsContextPrivate(); Seems unnnecessary. The default destructor will do the job. + int width = ((s == BSTop || s == BSBottom) ? y2 - y1 : x2 - x1 ); Space before that last parenthesis looks strange to me. Maybe remove the outer parentheses altogether? Adding these values directly to Frame rather than to FramePrivate seems like it might be moving in the wrong direction. Not sure. Are we planning to get rid of FramePrivate? I think recordFormValue should take a PassRefPtr rather than a raw pointer. Seems OK to land as-is. r=me

Eric Seidel (no email)

Comment 3 2006-03-19 21:08:09 PST

Created attachment 7181 [details] Same patch, updated after rename changes.

Eric Seidel (no email)

Comment 4 2006-03-19 21:23:01 PST

Created attachment 7182 [details] Better patch, with darin's suggested changes.

Eric Seidel (no email)

Comment 5 2006-03-19 21:35:38 PST

Created attachment 7183 [details] Better patch, now also moving all Frame members to FramePrivate

Darin Adler

Comment 6 2006-03-19 21:37:27 PST

Comment on attachment 7183 [details] Better patch, now also moving all Frame members to FramePrivate r=me

Note You need to log in before you can comment on or make changes to this bug.