Push parts of form submission code down into Frame.cpp

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

Push parts of form submission code down into Frame.cpp

If this form submits, we'll know the patch works. :)

[Eric Seidel (no email)]

Created attachment 7145 [details]
push parts of MacFrame into Frame, GraphicsContextMac into GraphicsContext

4th attempt to post this patch.

[Darin Adler]

Comment on attachment 7145 [details]
push parts of MacFrame into Frame, GraphicsContextMac into GraphicsContext

I'd think you could just rename drawFloatImage to drawImage.

+    ~GraphicsContextPrivate();

Seems unnnecessary. The default destructor will do the job.

+    int width = ((s == BSTop || s == BSBottom) ? y2 - y1 : x2 - x1 );

Space before that last parenthesis looks strange to me. Maybe remove the outer parentheses altogether?

Adding these values directly to Frame rather than to FramePrivate seems like it might be moving in the wrong direction. Not sure. Are we planning to get rid of FramePrivate?

I think recordFormValue should take a PassRefPtr rather than a raw pointer.

Seems OK to land as-is. r=me

[Eric Seidel (no email)]

Created attachment 7181 [details]
Same patch, updated after rename changes.

[Eric Seidel (no email)]

Created attachment 7182 [details]
Better patch, with darin's suggested changes.

[Eric Seidel (no email)]

Created attachment 7183 [details]
Better patch, now also moving all Frame members to FramePrivate

[Darin Adler]

Comment on attachment 7183 [details]
Better patch, now also moving all Frame members to FramePrivate

r=me