Bug 78236

Summary: Web Inspector: [TextPrompt] TAB should complete suggestions up to their common prefix in Console
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch vsevik: review+

Description Alexander Pavlov (apavlov) 2012-02-09 07:19:26 PST 
Patch to follow.

Upstreaming http://code.google.com/p/chromium/issues/detail?id=112283
Comment 1 Alexander Pavlov (apavlov) 2012-02-09 07:45:03 PST 
Created attachment 126302 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-02-10 07:25:54 PST 
Comment on attachment 126302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126302&action=review

> Source/WebCore/inspector/front-end/TextPrompt.js:445
> +            }

Please extract this method.

> Source/WebCore/inspector/front-end/TextPrompt.js:516
> +        if (!this.autoCompleteElement || !this._commonPrefix || !this._userEnteredText || this._userEnteredText.length >= this._commonPrefix.length)

We'd better check that user entered text is prefix of common prefix.
Comment 3 Alexander Pavlov (apavlov) 2012-02-10 07:42:02 PST 
Committed r107402: <http://trac.webkit.org/changeset/107402>