Summary: | Code generators should support multiple values for the [CallWith=] attribute | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, darin, japhet, ojan, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 77393 | ||||||||
Attachments: |
|
Description
Kentaro Hara
2012-02-09 05:13:08 PST
Created attachment 126287 [details]
Patch
Attachment 126287 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:326: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:341: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:1202: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:1215: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:1229: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:1246: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:1264: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:1277: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 8 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style. Comment on attachment 126287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126287&action=review > Source/WebCore/bindings/scripts/CodeGenerator.pm:641 > +sub CallWithContains This doesn't seem specific to CallWith. Should we give this a more general name like "ExtendedAttributeContains" or "AttributeContains"? > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1457 > sub GenerateCallWith Should this function error out if there's something in the CallWith attribute that we don't understand? Created attachment 126407 [details]
rebased patch for commit
(In reply to comment #3) > (From update of attachment 126287 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126287&action=review > > > Source/WebCore/bindings/scripts/CodeGenerator.pm:641 > > +sub CallWithContains > > This doesn't seem specific to CallWith. Should we give this a more general name like "ExtendedAttributeContains" or "AttributeContains"? Makes sense. Renamed to "ExtendedAttributeContains". > > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1457 > > sub GenerateCallWith > > Should this function error out if there's something in the CallWith attribute that we don't understand? For now I would like to skip it. I am planning to implement "IDL attribute checker" after cleaning up all IDLs, and include the CallWith values check there. Committed r107314: <http://trac.webkit.org/changeset/107314> Comment on attachment 126287 [details]
Patch
Landed manually to avoid style check errors in generated code.
|