Bug 78222

Summary:

Web Inspector: Timeline memory graph would have been more useful if it had used minUsedHeapSize as the lower bound. Currently it uses zero as the lower bound.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
screenshot	none
Patch	none
Patch	pfeldman: review+

Ilya Tikhonovsky

Reported 2012-02-09 04:31:29 PST

%subj%

Attachments
screenshot (39.96 KB, image/png) 2012-02-09 04:38 PST, Ilya Tikhonovsky	no flags	Details
Patch (4.93 KB, patch) 2012-02-09 04:42 PST, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
Patch (4.86 KB, patch) 2012-02-09 04:58 PST, Ilya Tikhonovsky	pfeldman: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2012-02-09 04:38:11 PST

Created attachment 126280 [details] screenshot

Ilya Tikhonovsky

Comment 2 2012-02-09 04:42:03 PST

Created attachment 126281 [details] Patch

Pavel Feldman

Comment 3 2012-02-09 04:45:47 PST

Comment on attachment 126281 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126281&action=review > Source/WebCore/inspector/front-end/TimelineOverviewPane.js:582 > + var delta = (maxUsedHeapSize - minUsedHeapSize) * 0.05; Why not to shift the entire graph 5px?

Ilya Tikhonovsky

Comment 4 2012-02-09 04:58:54 PST

Created attachment 126283 [details] Patch

Ilya Tikhonovsky

Comment 5 2012-02-09 05:04:33 PST

Committed r107223: <http://trac.webkit.org/changeset/107223>

Note You need to log in before you can comment on or make changes to this bug.