Bug 78222

Summary: Web Inspector: Timeline memory graph would have been more useful if it had used minUsedHeapSize as the lower bound. Currently it uses zero as the lower bound.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
screenshot
none
Patch
none
Patch pfeldman: review+

Description Ilya Tikhonovsky 2012-02-09 04:31:29 PST
%subj%
Comment 1 Ilya Tikhonovsky 2012-02-09 04:38:11 PST
Created attachment 126280 [details]
screenshot
Comment 2 Ilya Tikhonovsky 2012-02-09 04:42:03 PST
Created attachment 126281 [details]
Patch
Comment 3 Pavel Feldman 2012-02-09 04:45:47 PST
Comment on attachment 126281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126281&action=review

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:582
> +        var delta = (maxUsedHeapSize - minUsedHeapSize) * 0.05;

Why not to shift the entire graph 5px?
Comment 4 Ilya Tikhonovsky 2012-02-09 04:58:54 PST
Created attachment 126283 [details]
Patch
Comment 5 Ilya Tikhonovsky 2012-02-09 05:04:33 PST
Committed r107223: <http://trac.webkit.org/changeset/107223>