Bug 78209

Summary: Perf-o-matic should update memcache in taskqueue
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit WebsiteAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, morrita
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
Fixes the bug abarth: review+

Ryosuke Niwa
Reported 2012-02-09 00:14:45 PST
webkit-perf.appspot.com takes forever to load right now because we update manifest, dashboard, etc... on demand. It creates memcache on demand but we should be doing in taskqueue instead.
Attachments
Fixes the bug (16.88 KB, patch)
2012-02-09 00:24 PST, Ryosuke Niwa 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-02-09 00:24:23 PST
Created attachment 126251 [details] Fixes the bug
Ryosuke Niwa
Comment 2 2012-02-09 00:33:43 PST
FWIW, I've already pushed this version to webkit-perf.appspot.com.
Adam Barth
Comment 3 2012-02-09 11:49:22 PST
Comment on attachment 126251 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=126251&action=review > Websites/webkit-perf.appspot.com/controller.py:47 > + self.response.headers['Content-Type'] = 'application/json; charset=utf-8' You shouldn't need a charset parameter for application/json. It's always UTF-8. charset parameters are only for text/... MIME types. > Websites/webkit-perf.appspot.com/controller.py:65 > + self.response.headers['Content-Type'] = 'application/json; charset=utf-8' ditto > Websites/webkit-perf.appspot.com/controller.py:83 > + self.response.headers['Content-Type'] = 'application/json; charset=utf-8' ditto
Ryosuke Niwa
Comment 4 2012-02-09 11:53:50 PST
Comment on attachment 126251 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=126251&action=review >> Websites/webkit-perf.appspot.com/controller.py:47 >> + self.response.headers['Content-Type'] = 'application/json; charset=utf-8' > > You shouldn't need a charset parameter for application/json. It's always UTF-8. charset parameters are only for text/... MIME types. I see. Will fix.
Ryosuke Niwa
Comment 5 2012-02-09 12:20:45 PST
Committed r107274: <http://trac.webkit.org/changeset/107274>
Note You need to log in before you can comment on or make changes to this bug.