| Summary: | merge message_broker.py into manager_worker_broker.py | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||||||||
| Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | abarth, ojan, tony, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 78181, 78997, 78999, 79000 | ||||||||||||||
| Bug Blocks: | 78185 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Dirk Pranke
2012-02-08 17:40:22 PST
Created attachment 126205 [details]
Patch
Created attachment 127316 [details] merge to r107844 + patch in bug 78181 Tony, can you take a look at this, too? (hopefully the last one for a little while) Comment on attachment 127316 [details] merge to r107844 + patch in bug 78181 Can you rebase to ToT and upload? I want to see the side by side diff. Created attachment 127458 [details] diff from r107844 w/o 78181's change I've updated the description of the second attachment, and added a third. I'm not sure what definition of ToT you're looking for, but it should be (more or less) one of those two? (In reply to comment #6) > I've updated the description of the second attachment, and added a third. I'm not sure what definition of ToT you're looking for, but it should be (more or less) one of those two? Can you land the patch in bug 78181 then upload a clean diff against ToT? I want to use the side-by-side feature of the patch review tool because it's hard to tell what's an indention change vs a move. I guess you could also split that into two patches. (In reply to comment #7) > Can you land the patch in bug 78181 then upload a clean diff against ToT? Ah, sure ... will post shortly. Created attachment 127476 [details] merge to r108005 (after fix to bug 78181) Please take another look when you get a chance? (no hurry). Created attachment 127721 [details] merge to r108177 Comment on attachment 127721 [details] merge to r108177 cancelling review - I've broken this patch up into three separate patches so hopefully it'll be easier to review. closing - the sub-bugs are closed. |