Bug 78179

Summary: version_check.py should inform users that we don't support Python 2.5 anymore
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric: review+

Description Adam Barth 2012-02-08 16:41:48 PST
version_check.py should inform users that we don't support Python 2.5 anymore
Comment 1 Adam Barth 2012-02-08 16:44:24 PST
Created attachment 126187 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-08 16:45:01 PST
Comment on attachment 126187 [details]
Patch

Does this have unittests we need to update?
Comment 3 Adam Barth 2012-02-08 16:46:16 PST
Committed r107155: <http://trac.webkit.org/changeset/107155>
Comment 4 Adam Barth 2012-02-08 16:50:22 PST
Not that I found.
Comment 5 Dirk Pranke 2012-02-08 17:08:44 PST
(In reply to comment #2)
> (From update of attachment 126187 [details])
> Does this have unittests we need to update?

No. When I wrote this, I argued that the code was too simple to write and too hard to test to be worth unit-testing, and I still think that that's true :).