Bug 78174

Summary: [PerformanceTests] sunspider-crypto-md5.html and sunspider-crypto-sha1.html are timing out on cr-mac perf bot
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, mjs, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
Patch none

Attachments
Patch (18.33 KB, patch)
2012-02-08 17:49 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-02-08 16:30:11 PST
These tests are distributed under BSD-license: /* * A JavaScript implementation of the Secure Hash Algorithm, SHA-1, as defined * in FIPS PUB 180-1 * Version 2.1a Copyright Paul Johnston 2000 - 2002. * Other contributors: Greg Holt, Andrew Kepert, Ydnar, Lostinet * Distributed under the BSD License * See http://pajhome.org.uk/crypt/md5 for details. */ But on the other hand, we already have Sunspier under PerformanceTests/SunSpider. So I guess it's OK to have them, especially WebKit binary doesn't contains them at all. I'll pull them back.
Ryosuke Niwa
Comment 2 2012-02-08 16:39:37 PST
(In reply to comment #1) > These tests are distributed under BSD-license: > > /* > * A JavaScript implementation of the Secure Hash Algorithm, SHA-1, as defined > * in FIPS PUB 180-1 > * Version 2.1a Copyright Paul Johnston 2000 - 2002. > * Other contributors: Greg Holt, Andrew Kepert, Ydnar, Lostinet > * Distributed under the BSD License > * See http://pajhome.org.uk/crypt/md5 for details. > */ > > But on the other hand, we already have Sunspier under PerformanceTests/SunSpider. > So I guess it's OK to have them, especially WebKit binary doesn't contains them at all. > I'll pull them back. Okay. Btw, can we just share SunSpider .js files instead of having an extra copy inside Dromaeo/resources?
Hajime Morrita
Comment 3 2012-02-08 16:59:24 PST
(In reply to comment #2) > Okay. Btw, can we just share SunSpider .js files instead of having an extra copy inside Dromaeo/resources? Not automatically. It appends a boilerplate html round these JS files. I think we can just keep it as is, especially because there are several version of SunSupider.
Hajime Morrita
Comment 4 2012-02-08 17:49:08 PST
Created attachment 126207 [details] Patch
WebKit Review Bot
Comment 5 2012-02-08 23:14:39 PST
Comment on attachment 126207 [details] Patch Clearing flags on attachment: 126207 Committed r107184: <http://trac.webkit.org/changeset/107184>
WebKit Review Bot
Comment 6 2012-02-08 23:14:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.