Summary: | [chromium] Add method to WebPluginContainer to check if a rectangle is topmost | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Viet-Trung Luu <viettrungluu> | ||||||
Component: | New Bugs | Assignee: | Viet-Trung Luu <viettrungluu> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, fishd, viettrungluu, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Viet-Trung Luu
2012-02-08 15:34:49 PST
Created attachment 126168 [details]
Patch
This is needed by Pepper Flash to ensure that the "Flash dialogs" aren't covered by anything. Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. @fishd - ping Comment on attachment 126168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126168&action=review > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:438 > +bool WebPluginContainerImpl::isRectTopmost(const WebRect& rect) I think it would probably be better from an API point of view to instead add a WebView::hitTestAtPoint method. You might also add a method to map plugin coordinates to window coordinates. Trung and I discussed this, and it looks like hit testing is not so simple to generalize. Comment on attachment 126168 [details] Patch Rejecting attachment 126168 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: --chromium', '--force-update']" exit_code: 2 Updating OpenSource git.webkit.org[0: 17.254.20.231]: errno=Connection refused fatal: unable to connect a socket (Connection refused) Died at Tools/Scripts/update-webkit line 162. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource git.webkit.org[0: 17.254.20.231]: errno=Connection refused fatal: unable to connect a socket (Connection refused) Died at Tools/Scripts/update-webkit line 162. Full output: http://queues.webkit.org/results/11531284 Created attachment 127401 [details]
Patch
Comment on attachment 127401 [details] Patch Clearing flags on attachment: 127401 Committed r107960: <http://trac.webkit.org/changeset/107960> All reviewed patches have been landed. Closing bug. |