Bug 78166 – [chromium] Add method to WebPluginContainer to check if a rectangle is topmost

• Component: New Bugs
• Status: RESOLVED FIXED

[Viet-Trung Luu]

[chromium] Add method to WebPluginContainer to check if a rectangle is topmost

[Viet-Trung Luu]

Created attachment 126168 [details]
Patch

[Viet-Trung Luu]

This is needed by Pepper Flash to ensure that the "Flash dialogs" aren't covered by anything.

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Viet-Trung Luu]

@fishd - ping

[Darin Fisher (:fishd, Google)]

Comment on attachment 126168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126168&action=review

> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:438
> +bool WebPluginContainerImpl::isRectTopmost(const WebRect& rect)

I think it would probably be better from an API point of view to instead add
a WebView::hitTestAtPoint method.  You might also add a method to map plugin
coordinates to window coordinates.

[Darin Fisher (:fishd, Google)]

Trung and I discussed this, and it looks like hit testing is not so simple to generalize.

[WebKit Review Bot]

Comment on attachment 126168 [details]
Patch

Rejecting attachment 126168 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
--chromium', '--force-update']" exit_code: 2

Updating OpenSource
git.webkit.org[0: 17.254.20.231]: errno=Connection refused
fatal: unable to connect a socket (Connection refused)
Died at Tools/Scripts/update-webkit line 162.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
git.webkit.org[0: 17.254.20.231]: errno=Connection refused
fatal: unable to connect a socket (Connection refused)
Died at Tools/Scripts/update-webkit line 162.

Full output: http://queues.webkit.org/results/11531284

[Viet-Trung Luu]

Created attachment 127401 [details]
Patch

[WebKit Review Bot]

Comment on attachment 127401 [details]
Patch

Clearing flags on attachment: 127401

Committed r107960: <http://trac.webkit.org/changeset/107960>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.