Summary: | Remove simplejson because it's no longer used by webkitpy | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ossy, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 71593 | ||||||
Attachments: |
|
Description
Adam Barth
2012-02-08 15:28:53 PST
Created attachment 126164 [details]
Patch
Committed r107141: <http://trac.webkit.org/changeset/107141> (In reply to comment #2) > Committed r107141: <http://trac.webkit.org/changeset/107141> Reopen, because this change broke the unittest of master.cfg: File "./mastercfg_unittest.py", line 31, in _add_dependant_modules_to_sys_modules from webkitpy.thirdparty import simplejson ImportError: cannot import name simplejson Should we revert this change? Nope. mastercfg_unittest should be changed to just import the built-in version of json. Fix for test in https://bugs.webkit.org/show_bug.cgi?id=79070 |