| Summary: | r107042 caused compile breakages on chromium try bots | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Podivilov <podivilov> | ||||
| Component: | Platform | Assignee: | James Robinson <jamesr> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, jamesr | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Pavel Podivilov
2012-02-08 09:52:42 PST
Looks like platform_api_copy_webcore_headers action added in http://trac.webkit.org/changeset/107042 is sometimes performed in parallel with compiling sources: --------------------Configuration: webkit_platform - Release|Win32------------- Compiling... WebFloatQuad.cpp e:\b\build\slave\win\build\src\third_party\webkit\source\platform\chromium\public\WebFloatPoint.h(37) : fatal error C1083: Cannot open include file: 'FloatPoint.h': No such file or directory WebCString.cpp WebString.cpp Copying WebCore headers needed by Platform API webkit_platform - 1 error(s), 0 warning(s) Created attachment 126124 [details]
Patch
Comment on attachment 126124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126124&action=review > Source/Platform/Platform.gyp/Platform.gyp:91 > + 'destination': '<(output_dir)', Not SHARED_INTERMEDIATE_DIR ? output_dir is <(SHARED_INTERMEDIATE_DIR)/webcore_headers - see the variables section Comment on attachment 126124 [details]
Patch
r=me
Committed r107110: <http://trac.webkit.org/changeset/107110> |