Bug 78125

Summary: r107042 caused compile breakages on chromium try bots
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: PlatformAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+

Pavel Podivilov
Reported 2012-02-08 09:52:42 PST
--------------------Configuration: webkit_platform - Release|Win32------------- Compiling... WebFloatQuad.cpp e:\b\build\slave\win\build\src\third_party\webkit\source\platform\chromium\public\WebFloatPoint.h(37) : fatal error C1083: Cannot open include file: 'FloatPoint.h': No such file or directory WebCString.cpp WebString.cpp Copying WebCore headers needed by Platform API webkit_platform - 1 error(s), 0 warning(s)
Attachments
Patch (4.36 KB, patch)
2012-02-08 11:19 PST, James Robinson 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2012-02-08 09:53:12 PST
Looks like platform_api_copy_webcore_headers action added in http://trac.webkit.org/changeset/107042 is sometimes performed in parallel with compiling sources: --------------------Configuration: webkit_platform - Release|Win32------------- Compiling... WebFloatQuad.cpp e:\b\build\slave\win\build\src\third_party\webkit\source\platform\chromium\public\WebFloatPoint.h(37) : fatal error C1083: Cannot open include file: 'FloatPoint.h': No such file or directory WebCString.cpp WebString.cpp Copying WebCore headers needed by Platform API webkit_platform - 1 error(s), 0 warning(s)
James Robinson
Comment 2 2012-02-08 11:19:44 PST
Created attachment 126124 [details] Patch
Adam Barth
Comment 3 2012-02-08 11:24:01 PST
Comment on attachment 126124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126124&action=review > Source/Platform/Platform.gyp/Platform.gyp:91 > + 'destination': '<(output_dir)', Not SHARED_INTERMEDIATE_DIR ?
James Robinson
Comment 4 2012-02-08 11:24:32 PST
output_dir is <(SHARED_INTERMEDIATE_DIR)/webcore_headers - see the variables section
Adam Barth
Comment 5 2012-02-08 11:28:30 PST
Comment on attachment 126124 [details] Patch r=me
James Robinson
Comment 6 2012-02-08 11:30:11 PST
Committed r107110: <http://trac.webkit.org/changeset/107110>
Note You need to log in before you can comment on or make changes to this bug.