Bug 78110

Summary: Make animation events non-cancelable
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, dino, esprehn+autocc, kangil.han, simon.fraser
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dbates: review+

Description Simon Fraser (smfr) 2012-02-08 06:00:10 PST 
Due to resolution of https://www.w3.org/Bugs/Public/show_bug.cgi?id=14797.
Comment 1 Simon Fraser (smfr) 2016-03-24 22:43:24 PDT 
Created attachment 274885 [details]
Patch
Comment 2 Daniel Bates 2016-03-24 22:53:33 PDT 
Comment on attachment 274885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274885&action=review

> LayoutTests/animations/animation-events-not-cancelable.html:1
> +<html>

Please add <!DOCTYPE html> to the top of this file.

> LayoutTests/animations/animation-events-not-cancelable.html:32
> +box.addEventListener('animationstart', function(event) {

This file alternatives between using single quoted string literals and double quoted string literals. I suggest that we pick one style and stick with it throughout this file for consistency.
Comment 3 Simon Fraser (smfr) 2016-03-24 22:57:45 PDT 
Created attachment 274886 [details]
Patch
Comment 4 Daniel Bates 2016-03-24 23:04:01 PDT 
Comment on attachment 274886 [details]
Patch

I take it you disagreed about picking one style for string literals?
Comment 5 Simon Fraser (smfr) 2016-03-24 23:16:17 PDT 
No, I hadn't seen your comment. Will fix.
Comment 6 Simon Fraser (smfr) 2016-03-30 09:25:40 PDT 
https://trac.webkit.org/r198837