Bug 78110 - Make animation events non-cancelable
Summary: Make animation events non-cancelable
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: WebExposed
Depends on:
Reported: 2012-02-08 06:00 PST by Simon Fraser (smfr)
Modified: 2016-03-30 09:25 PDT (History)
7 users (show)

See Also:

Patch (4.30 KB, patch)
2016-03-24 22:43 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (4.22 KB, patch)
2016-03-24 22:57 PDT, Simon Fraser (smfr)
dbates: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-02-08 06:00:10 PST
Due to resolution of https://www.w3.org/Bugs/Public/show_bug.cgi?id=14797.
Comment 1 Simon Fraser (smfr) 2016-03-24 22:43:24 PDT
Created attachment 274885 [details]
Comment 2 Daniel Bates 2016-03-24 22:53:33 PDT
Comment on attachment 274885 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=274885&action=review

> LayoutTests/animations/animation-events-not-cancelable.html:1
> +<html>

Please add <!DOCTYPE html> to the top of this file.

> LayoutTests/animations/animation-events-not-cancelable.html:32
> +box.addEventListener('animationstart', function(event) {

This file alternatives between using single quoted string literals and double quoted string literals. I suggest that we pick one style and stick with it throughout this file for consistency.
Comment 3 Simon Fraser (smfr) 2016-03-24 22:57:45 PDT
Created attachment 274886 [details]
Comment 4 Daniel Bates 2016-03-24 23:04:01 PDT
Comment on attachment 274886 [details]

I take it you disagreed about picking one style for string literals?
Comment 5 Simon Fraser (smfr) 2016-03-24 23:16:17 PDT
No, I hadn't seen your comment. Will fix.
Comment 6 Simon Fraser (smfr) 2016-03-30 09:25:40 PDT