WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
78110
Make animation events non-cancelable
https://bugs.webkit.org/show_bug.cgi?id=78110
Summary
Make animation events non-cancelable
Simon Fraser (smfr)
Reported
2012-02-08 06:00:10 PST
Due to resolution of
https://www.w3.org/Bugs/Public/show_bug.cgi?id=14797
.
Attachments
Patch
(4.30 KB, patch)
2016-03-24 22:43 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(4.22 KB, patch)
2016-03-24 22:57 PDT
,
Simon Fraser (smfr)
dbates
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2016-03-24 22:43:24 PDT
Created
attachment 274885
[details]
Patch
Daniel Bates
Comment 2
2016-03-24 22:53:33 PDT
Comment on
attachment 274885
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=274885&action=review
> LayoutTests/animations/animation-events-not-cancelable.html:1 > +<html>
Please add <!DOCTYPE html> to the top of this file.
> LayoutTests/animations/animation-events-not-cancelable.html:32 > +box.addEventListener('animationstart', function(event) {
This file alternatives between using single quoted string literals and double quoted string literals. I suggest that we pick one style and stick with it throughout this file for consistency.
Simon Fraser (smfr)
Comment 3
2016-03-24 22:57:45 PDT
Created
attachment 274886
[details]
Patch
Daniel Bates
Comment 4
2016-03-24 23:04:01 PDT
Comment on
attachment 274886
[details]
Patch I take it you disagreed about picking one style for string literals?
Simon Fraser (smfr)
Comment 5
2016-03-24 23:16:17 PDT
No, I hadn't seen your comment. Will fix.
Simon Fraser (smfr)
Comment 6
2016-03-30 09:25:40 PDT
https://trac.webkit.org/r198837
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug