Bug 78096

Summary: Rename [HasNumericIndexGetter] to [NumericIndexedGetter]
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77393    
Attachments:
Description Flags
Patch
abarth: review+, webkit.review.bot: commit-queue-
rebased patch for commit none

Kentaro Hara
Reported 2012-02-08 02:54:24 PST
We can rename [HasNumericIndexGetter] to [NumericIndexedGetter], for naming consistency with [IndexedGetter] and [CustomIndexedGetter].
Attachments
Patch (19.97 KB, patch)
2012-02-08 02:58 PST, Kentaro Hara 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
rebased patch for commit (20.00 KB, patch)
2012-02-08 16:08 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-08 02:58:25 PST
Created attachment 126040 [details] Patch
WebKit Review Bot
Comment 2 2012-02-08 15:29:04 PST
Comment on attachment 126040 [details] Patch Rejecting attachment 126040 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10594 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 10594. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/11462602
Kentaro Hara
Comment 3 2012-02-08 16:08:19 PST
Created attachment 126176 [details] rebased patch for commit
WebKit Review Bot
Comment 4 2012-02-08 22:43:34 PST
Comment on attachment 126176 [details] rebased patch for commit Clearing flags on attachment: 126176 Committed r107181: <http://trac.webkit.org/changeset/107181>
Note You need to log in before you can comment on or make changes to this bug.