Bug 78076

Summary: Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, ojan, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77393    
Attachments:
Description Flags
Patch
none
patch for commit none

Description Kentaro Hara 2012-02-07 21:26:31 PST 
We can rename the [HasOverridingNameGetter] attribute to the [CustomNamedGetter] attribute, for naming consistency with [CustomNamedSetter].
Comment 1 Kentaro Hara 2012-02-07 21:29:48 PST 
Created attachment 125995 [details]
Patch
Comment 2 Adam Barth 2012-02-07 21:31:07 PST 
Comment on attachment 125995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125995&action=review

> Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl:32
> -        HasOverridingNameGetter
> +        CustomNamedGetter

Should we change the name of this test file since it refers to the old attribute name?
Comment 3 Kentaro Hara 2012-02-07 21:41:25 PST 
Created attachment 125997 [details]
patch for commit
Comment 4 Kentaro Hara 2012-02-07 21:48:05 PST 
Committed r107039: <http://trac.webkit.org/changeset/107039>
Comment 5 Kentaro Hara 2012-02-07 21:49:29 PST 
Comment on attachment 125995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125995&action=review

>> Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl:32
>> +        CustomNamedGetter
> 
> Should we change the name of this test file since it refers to the old attribute name?

Nice catch. Renamed the file to TestCustomNamedGetter.idl, and committed manually (to avoid style check errors).