Bug 78062

Summary: DFG should have polymorphic put_by_id caching
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
none
the patch
none
the patch oliver: review+

Description Filip Pizlo 2012-02-07 17:40:32 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2012-02-07 17:40:48 PST
<rdar://problem/10326439>
Comment 2 Filip Pizlo 2012-02-07 17:47:10 PST
Created attachment 125968 [details]
the patch

Still need some build foo, but other than that it seems to work.
Comment 3 WebKit Review Bot 2012-02-07 17:56:24 PST
Attachment 125968 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/bytecode/PolymorphicPutByIdList.h:156:  The parameter name "putKind" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/bytecode/PolymorphicPutByIdList.h:157:  The parameter name "stubInfo" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/bytecode/StructureStubInfo.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Filip Pizlo 2012-02-07 18:02:32 PST
Created attachment 125971 [details]
the patch

Added build goodness.
Comment 5 WebKit Review Bot 2012-02-07 18:03:44 PST
Attachment 125971 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1

Source/JavaScriptCore/bytecode/StructureStubInfo.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Filip Pizlo 2012-02-07 18:37:46 PST
Created attachment 125979 [details]
the patch
Comment 7 WebKit Review Bot 2012-02-07 18:40:29 PST
Attachment 125979 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1

Source/JavaScriptCore/bytecode/StructureStubInfo.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Oliver Hunt 2012-02-10 09:58:34 PST
Comment on attachment 125979 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125979&action=review

No baseline support? :-D

Once this is in we can add support for setters!!!!

> Source/JavaScriptCore/runtime/WriteBarrier.h:82
> +    
> +    // This is meant to be used like operator=, but is called copyFrom instead, in
> +    // order to kindly inform the C++ compiler that its advice is not appreciated.
> +    void copyFrom(const WriteBarrierBase<T>& other)
> +    {
> +        m_cell = other.m_cell;
> +    }

What was it complaining about?
Comment 9 Filip Pizlo 2012-02-11 13:34:02 PST
Landed in http://trac.webkit.org/changeset/107485