Summary: | Plumb through webGLErrorsToConsoleEnable in WebSettings | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gregg Tavares <gman> | ||||||
Component: | WebGL | Assignee: | Gregg Tavares <gman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | fishd, kbr, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Gregg Tavares
2012-02-07 17:37:19 PST
Created attachment 125966 [details]
Patch
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. Comment on attachment 125966 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125966&action=review Looks fine to me. I can't imagine this being contentious and fishd's on vacation so I'm r+'ing it. > Source/WebKit/chromium/ChangeLog:3 > + Plum through webGLErrorsToConsoleEnable in WebSettings Minor nit: plum -> plumb everywhere. Created attachment 125973 [details]
Patch
Comment on attachment 125973 [details]
Patch
Looks good. r=me again
Comment on attachment 125973 [details] Patch Clearing flags on attachment: 125973 Committed r107037: <http://trac.webkit.org/changeset/107037> All reviewed patches have been landed. Closing bug. |