Bug 78049

Summary: [BlackBerry] Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBerry and IconDatabaseClientBlackBerry classes
Product: WebKit Reporter: Jacky Jiang <jkjiang>
Component: New BugsAssignee: Jacky Jiang <jkjiang>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, rwlbuis, tonikitoo, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Jacky Jiang 2012-02-07 15:10:38 PST 
Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBerry and IconDatabaseClientBlackBerry classes.
Comment 1 Jacky Jiang 2012-02-07 15:47:03 PST 
Created attachment 125946 [details]
Patch
Comment 2 Rob Buis 2012-02-07 15:52:40 PST 
Comment on attachment 125946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125946&action=review

Some small nits.

> Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp:32
> +        instance = new IconDatabaseClientBlackBerry();

Can you use DEFINE_STATIC_LOCAL?

> Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp:60
> +    return (m_initState == InitializeSucceeded);

No need for parentheses.

> Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.h:40
> +public:

Better move the public section up above the private, this is the standard.
Comment 3 Jacky Jiang 2012-02-08 16:09:13 PST 
Created attachment 126178 [details]
Patch

Update the patch except the DEFINE_STATIC_LOCAL which doesn't seem to work well.
Comment 4 Jacky Jiang 2012-02-08 16:11:55 PST 
Comment on attachment 126178 [details]
Patch

Typo in commit log, will update.
Comment 5 Jacky Jiang 2012-02-08 16:17:29 PST 
Created attachment 126180 [details]
Patch
Comment 6 Rob Buis 2012-02-08 18:05:37 PST 
Comment on attachment 126180 [details]
Patch

Looks good.
Comment 7 WebKit Review Bot 2012-02-08 23:02:20 PST 
Comment on attachment 126180 [details]
Patch

Clearing flags on attachment: 126180

Committed r107183: <http://trac.webkit.org/changeset/107183>
Comment 8 WebKit Review Bot 2012-02-08 23:02:34 PST 
All reviewed patches have been landed.  Closing bug.