Bug 78017

Summary:

move warning about css values and render style constants closer to where it applies

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

macpherson, menard, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
patch2	none

Description Tony Chang 2012-02-07 12:13:50 PST

move warning about css values and render style constants closer to where it applies

Comment 1 Tony Chang 2012-02-07 12:17:00 PST

Created attachment 125897 [details]
Patch

Comment 2 Darin Adler 2012-02-07 12:21:38 PST

Comment on attachment 125897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125897&action=review

> Source/WebCore/css/CSSValueKeywords.in:11
> +// The order here should match the order of the EBorderStyle enum in RenderStyleConstants.h.

s/should/must/

Comment 3 Tony Chang 2012-02-07 12:26:59 PST

Created attachment 125899 [details]
patch2

Comment 4 WebKit Review Bot 2012-02-07 13:22:46 PST

Comment on attachment 125899 [details]
patch2

Clearing flags on attachment: 125899

Committed r106980: <http://trac.webkit.org/changeset/106980>

Comment 5 WebKit Review Bot 2012-02-07 13:22:50 PST

All reviewed patches have been landed.  Closing bug.