Bug 78013

Summary:

[chromium] Gracefully handle compositor initialization failure in single-threaded proxy

Product:

WebKit

Reporter:

James Robinson <jamesr>

Component:

New Bugs

Assignee:

James Robinson <jamesr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cc-bugs, enne, kbr, vangelis, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	kbr: review+

Description James Robinson 2012-02-07 11:54:33 PST

[chromium] Gracefully handle compositor initialization failure in single-threaded proxy

Comment 1 James Robinson 2012-02-07 11:55:37 PST

Created attachment 125894 [details]
Patch

Comment 2 James Robinson 2012-02-07 13:11:24 PST

Created attachment 125908 [details]
Patch

Comment 3 James Robinson 2012-02-07 13:11:33 PST

Fixed the threaded case too

Comment 4 Kenneth Russell 2012-02-07 13:28:58 PST

Comment on attachment 125908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125908&action=review

Looks OK assuming it's been tested; one comment.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h:187
> +    bool updateLayers();

Please document the semantics of the return value. Why do some of the early outs in updateLayers return true?

Comment 5 James Robinson 2012-02-07 13:51:21 PST

Committed r106986: <http://trac.webkit.org/changeset/106986>