| Summary: | [BlackBerry] Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jacky Jiang <jkjiang> | ||||||
| Component: | New Bugs | Assignee: | Jacky Jiang <jkjiang> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dbates, rwlbuis, tonikitoo, webkit.review.bot, zimmermann | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 73144 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jacky Jiang
2012-02-07 08:36:54 PST
Assign to Jacky. Created attachment 125857 [details]
Patch
Comment on attachment 125857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125857&action=review I think this can be cleaned up a bit more. > Source/WebKit/blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.cpp:24 > +#include "Page.h" You don't need this include. > Source/WebKit/blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.h:25 > +#include <BlackBerryPlatformDeviceMotionTracker.h> You don't need this include, a forward class reference is enough. > Source/WebKit/blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.cpp:23 > +#include "Page.h" You don't need this include. > Source/WebKit/blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.h:25 > +#include <BlackBerryPlatformDeviceOrientationTracker.h> You don't need to include this, a forward reference should be ok. Created attachment 125890 [details]
Patch
Updated the patch based on Rob's comments.
Comment on attachment 125890 [details]
Patch
LGTM.
Comment on attachment 125890 [details] Patch Clearing flags on attachment: 125890 Committed r106976: <http://trac.webkit.org/changeset/106976> All reviewed patches have been landed. Closing bug. |