Bug 77993

Summary: [BlackBerry] Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes
Product: WebKit Reporter: Jacky Jiang <jkjiang>
Component: New BugsAssignee: Jacky Jiang <jkjiang>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, rwlbuis, tonikitoo, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
none
Patch none

Jacky Jiang
Reported 2012-02-07 08:36:54 PST
Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes.
Attachments
Patch (11.58 KB, patch)
2012-02-07 09:08 PST, Jacky Jiang 		no flags
DetailsFormatted DiffDiff
Patch (11.70 KB, patch)
2012-02-07 11:50 PST, Jacky Jiang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2012-02-07 08:56:03 PST
Assign to Jacky.
Jacky Jiang
Comment 2 2012-02-07 09:08:35 PST
Created attachment 125857 [details] Patch
Rob Buis
Comment 3 2012-02-07 10:36:29 PST
Comment on attachment 125857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125857&action=review I think this can be cleaned up a bit more. > Source/WebKit/blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.cpp:24 > +#include "Page.h" You don't need this include. > Source/WebKit/blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.h:25 > +#include <BlackBerryPlatformDeviceMotionTracker.h> You don't need this include, a forward class reference is enough. > Source/WebKit/blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.cpp:23 > +#include "Page.h" You don't need this include. > Source/WebKit/blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.h:25 > +#include <BlackBerryPlatformDeviceOrientationTracker.h> You don't need to include this, a forward reference should be ok.
Jacky Jiang
Comment 4 2012-02-07 11:50:04 PST
Created attachment 125890 [details] Patch Updated the patch based on Rob's comments.
Rob Buis
Comment 5 2012-02-07 11:59:04 PST
Comment on attachment 125890 [details] Patch LGTM.
WebKit Review Bot
Comment 6 2012-02-07 12:40:24 PST
Comment on attachment 125890 [details] Patch Clearing flags on attachment: 125890 Committed r106976: <http://trac.webkit.org/changeset/106976>
WebKit Review Bot
Comment 7 2012-02-07 12:40:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.