Bug 77980

Summary: [GTK] Include gdk-pixbuf in the jhbuild modules
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: WebKitGTKAssignee: Mario Sanchez Prada <mario>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, pnormand, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch gustavo: review+

Mario Sanchez Prada
Reported 2012-02-07 06:11:47 PST
We need to add gdk-pixbuf to the jhbuild modules to avoid breaking things if building with a too recent version of gdk-pixbuf, which would fail to find symbols provided by the new GIO's GResource, not present until glib 2.31.16 (we include 2.31.2 in WKGTK's jhbuild modules). We could raise glib up to 2.31.16, but this would cause even more trouble when trying to build libsoup (it will fail to link due to not finding g_module_open() while generating the introspection information) and so it seems more sensible to add gdk-pixbuf, instead. I'm thinking of gdk-pixbuf 2.35.5 since that's what we have installed in the bots now.
Attachments
Patch (1.85 KB, patch)
2012-02-07 06:14 PST, Mario Sanchez Prada 		no flags
DetailsFormatted DiffDiff
Patch (1.87 KB, patch)
2012-02-07 06:27 PST, Mario Sanchez Prada 		no flags
DetailsFormatted DiffDiff
Patch (1.87 KB, patch)
2012-02-07 07:00 PST, Mario Sanchez Prada 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2012-02-07 06:14:26 PST
Created attachment 125832 [details] Patch
Gustavo Noronha (kov)
Comment 2 2012-02-07 06:16:51 PST
Comment on attachment 125832 [details] Patch Attachment 125832 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11451001
Mario Sanchez Prada
Comment 3 2012-02-07 06:27:24 PST
Created attachment 125836 [details] Patch
Gustavo Noronha (kov)
Comment 4 2012-02-07 06:30:36 PST
Comment on attachment 125836 [details] Patch Attachment 125836 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11440284
Mario Sanchez Prada
Comment 5 2012-02-07 07:00:15 PST
Created attachment 125840 [details] Patch
Gustavo Noronha (kov)
Comment 6 2012-02-07 07:04:33 PST
Comment on attachment 125840 [details] Patch I've been wondering about our tarball usage, been thinking migrating all modules to git might be a good idea, but we can do all of them at once if we decide it's indeed a good idea =)
Mario Sanchez Prada
Comment 7 2012-02-07 07:22:16 PST
Committed r106936: <http://trac.webkit.org/changeset/106936>
Note You need to log in before you can comment on or make changes to this bug.