Summary: | [WK2] Text notifications should have an iconURL | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yael <yael> | ||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, jonlee, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 77969 | ||||||||
Attachments: |
|
Description
Yael
2012-02-07 04:56:33 PST
Created attachment 125828 [details]
Patch
Add an iconURL to WebNotification and add a public API to access it.
Comment on attachment 125828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125828&action=review I do not have reviewer status, but this otherwise looks good to me. > Source/WebKit2/UIProcess/API/C/WKNotification.cpp:50 > +WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification) icon should be capitalized. > Source/WebKit2/UIProcess/API/C/WKNotification.h:39 > +WK_EXPORT WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification); Ditto here. (In reply to comment #2) > (From update of attachment 125828 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125828&action=review > > I do not have reviewer status, but this otherwise looks good to me. > Thanks for reviewing :) > > Source/WebKit2/UIProcess/API/C/WKNotification.cpp:50 > > +WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification) > > icon should be capitalized. Sorry, will fix it. > > > Source/WebKit2/UIProcess/API/C/WKNotification.h:39 > > +WK_EXPORT WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification); > > Ditto here. Sorry, will fix it. Created attachment 125870 [details]
Patch.
Fix case of IconURL.
Comment on attachment 125870 [details] Patch. Clearing flags on attachment: 125870 Committed r107068: <http://trac.webkit.org/changeset/107068> All reviewed patches have been landed. Closing bug. |