Bug 77968

Summary: [WK2] Text notifications should have an iconURL
Product: WebKit Reporter: Yael <yael>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, jonlee, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77969    
Attachments:
Description Flags
Patch
none
Patch. none

Yael
Reported 2012-02-07 04:56:33 PST
Per http://www.w3.org/TR/notifications/ a simple text notification should have an iconURL. A patch is coming soon.
Attachments
Patch (10.86 KB, patch)
2012-02-07 05:54 PST, Yael 		no flags
DetailsFormatted DiffDiff
Patch. (10.86 KB, patch)
2012-02-07 10:13 PST, Yael 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2012-02-07 05:54:12 PST
Created attachment 125828 [details] Patch Add an iconURL to WebNotification and add a public API to access it.
Jon Lee
Comment 2 2012-02-07 10:01:28 PST
Comment on attachment 125828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125828&action=review I do not have reviewer status, but this otherwise looks good to me. > Source/WebKit2/UIProcess/API/C/WKNotification.cpp:50 > +WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification) icon should be capitalized. > Source/WebKit2/UIProcess/API/C/WKNotification.h:39 > +WK_EXPORT WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification); Ditto here.
Yael
Comment 3 2012-02-07 10:03:33 PST
(In reply to comment #2) > (From update of attachment 125828 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125828&action=review > > I do not have reviewer status, but this otherwise looks good to me. > Thanks for reviewing :) > > Source/WebKit2/UIProcess/API/C/WKNotification.cpp:50 > > +WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification) > > icon should be capitalized. Sorry, will fix it. > > > Source/WebKit2/UIProcess/API/C/WKNotification.h:39 > > +WK_EXPORT WKStringRef WKNotificationCopyiconURL(WKNotificationRef notification); > > Ditto here. Sorry, will fix it.
Yael
Comment 4 2012-02-07 10:13:48 PST
Created attachment 125870 [details] Patch. Fix case of IconURL.
WebKit Review Bot
Comment 5 2012-02-08 04:14:08 PST
Comment on attachment 125870 [details] Patch. Clearing flags on attachment: 125870 Committed r107068: <http://trac.webkit.org/changeset/107068>
WebKit Review Bot
Comment 6 2012-02-08 04:14:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.