Bug 77959

Summary: [GTK][WK2] enable-webaudio WebSetting
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61355    
Attachments:
Description Flags
Patch
gustavo: commit-queue-
Patch mrobinson: review+

Philippe Normand
Reported 2012-02-07 03:41:10 PST
SSIA
Attachments
Patch (7.09 KB, patch)
2012-02-07 03:42 PST, Philippe Normand 		gustavo: commit-queue-
DetailsFormatted DiffDiff
Patch (7.73 KB, patch)
2012-02-07 03:53 PST, Philippe Normand 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2012-02-07 03:42:42 PST
Created attachment 125804 [details] Patch
WebKit Review Bot
Comment 2 2012-02-07 03:45:51 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Gustavo Noronha (kov)
Comment 3 2012-02-07 03:50:25 PST
Comment on attachment 125804 [details] Patch Attachment 125804 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11438241
Philippe Normand
Comment 4 2012-02-07 03:53:15 PST
Created attachment 125808 [details] Patch
Carlos Garcia Campos
Comment 5 2012-02-07 03:58:46 PST
Comment on attachment 125808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125808&action=review Looks good to me > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:779 > + * WebKitSettings:enable-webaudio Missing trailing : WebKitSettings:enable-webaudio:
Philippe Normand
Comment 6 2012-02-08 00:06:36 PST
Committed r107044: <http://trac.webkit.org/changeset/107044>
Note You need to log in before you can comment on or make changes to this bug.