Bug 77959 - [GTK][WK2] enable-webaudio WebSetting
Summary: [GTK][WK2] enable-webaudio WebSetting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 61355
  Show dependency treegraph
 
Reported: 2012-02-07 03:41 PST by Philippe Normand
Modified: 2012-02-08 00:06 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.09 KB, patch)
2012-02-07 03:42 PST, Philippe Normand
gns: commit-queue-
Details | Formatted Diff | Diff
Patch (7.73 KB, patch)
2012-02-07 03:53 PST, Philippe Normand
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2012-02-07 03:41:10 PST
SSIA
Comment 1 Philippe Normand 2012-02-07 03:42:42 PST
Created attachment 125804 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-07 03:45:51 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Gustavo Noronha (kov) 2012-02-07 03:50:25 PST
Comment on attachment 125804 [details]
Patch

Attachment 125804 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11438241
Comment 4 Philippe Normand 2012-02-07 03:53:15 PST
Created attachment 125808 [details]
Patch
Comment 5 Carlos Garcia Campos 2012-02-07 03:58:46 PST
Comment on attachment 125808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125808&action=review

Looks good to me

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:779
> +     * WebKitSettings:enable-webaudio

Missing trailing :

WebKitSettings:enable-webaudio:
Comment 6 Philippe Normand 2012-02-08 00:06:36 PST
Committed r107044: <http://trac.webkit.org/changeset/107044>