Bug 77942

Summary: GTK & QT Rebaseline after r106912
Product: WebKit Reporter: Kaustubh Atrawalkar <kaustubh.ra>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kaustubh.ra, levin, ossy, pnormand, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 77961    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Kaustubh Atrawalkar
Reported 2012-02-07 00:45:12 PST
Rebaselining the tests after r106912.
Attachments
Patch (4.15 KB, patch)
2012-02-07 00:48 PST, Kaustubh Atrawalkar 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kaustubh Atrawalkar
Comment 1 2012-02-07 00:48:00 PST
Created attachment 125778 [details] Patch Re-committing the changes from http://trac.webkit.org/changeset/106105 & http://trac.webkit.org/changeset/105493
Kaustubh Atrawalkar
Comment 2 2012-02-07 00:52:52 PST
(In reply to comment #1) > Created an attachment (id=125778) [details] > Patch > > Re-committing the changes from http://trac.webkit.org/changeset/106105 & http://trac.webkit.org/changeset/105493 GTK Rebaseline as per - http://trac.webkit.org/changeset/105520
David Levin
Comment 3 2012-02-07 00:55:22 PST
Comment on attachment 125778 [details] Patch These should have been in your patch :(
Kaustubh Atrawalkar
Comment 4 2012-02-07 01:03:09 PST
(In reply to comment #3) > (From update of attachment 125778 [details]) > These should have been in your patch :( I know :( Ossy (Csaba Osztrogonac) had asked me to add in patch but I missed those. My mistake. So added immediately.
Csaba Osztrogonác
Comment 5 2012-02-07 02:08:27 PST
Comment on attachment 125778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125778&action=review Is there a bug report to fix these expected failures? > LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt:336 > +FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor]. Is this fail expected? > LayoutTests/platform/qt/fast/js/global-constructors-expected.txt:318 > +FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor]. Is this fail expected?
Kaustubh Atrawalkar
Comment 6 2012-02-07 02:12:02 PST
(In reply to comment #5) > (From update of attachment 125778 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125778&action=review > > Is there a bug report to fix these expected failures? > > > LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt:336 > > +FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor]. > > Is this fail expected? > > > LayoutTests/platform/qt/fast/js/global-constructors-expected.txt:318 > > +FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor]. > > Is this fail expected? Yes these are expected. need to fix the naming conventions for DOMURL. Currently there is no bug report filed. But will do it.
WebKit Review Bot
Comment 7 2012-02-07 02:23:00 PST
Comment on attachment 125778 [details] Patch Clearing flags on attachment: 125778 Committed r106915: <http://trac.webkit.org/changeset/106915>
WebKit Review Bot
Comment 8 2012-02-07 02:23:04 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 9 2012-02-07 03:52:03 PST
It was rolled out (http://trac.webkit.org/changeset/106922) because the original r106912 was rolled out too.
Csaba Osztrogonác
Comment 10 2012-02-07 03:57:05 PST
Otherwise please don't open new bug report for rebaseline after rXXXXX, but add it to the original bug.
Note You need to log in before you can comment on or make changes to this bug.