Bug 77933 – [EFL] Use modifier keys to execute pre-rendering.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[JungJik Lee]

I've changed the code to use modifier key to execute pre-rendering instead of using reserved function keys.
Because F10 fuction key is already reserved by system or ecore/efl, so eweblauncher can not catch the key event.
In addtion, we run out of function keys to map other features.
so that I remap the current pre-rendering function to shortcut keys by using modifier keys.

[JungJik Lee]

Created attachment 125792 [details]
proposal patch

[KwangHyuk]

Just a few idea is added.

> Tools/EWebLauncher/main.c:436
> +        modifierKey = modifierKey | ECORE_EVENT_MODIFIER_CTRL;

Why don't you use "modifierKey |= ECORE_EVENT_MODIFIER_CTRL;" ?

> Tools/EWebLauncher/main.c:565
> +    Evas_Event_Key_Up *ev = (Evas_Event_Key_Up*) event_info;

(Evas_Event_Key_Up*) ?

[JungJik Lee]

(In reply to comment #2)
> Just a few idea is added.
> 
> > Tools/EWebLauncher/main.c:436
> > +        modifierKey = modifierKey | ECORE_EVENT_MODIFIER_CTRL;
> 
> Why don't you use "modifierKey |= ECORE_EVENT_MODIFIER_CTRL;" ?
> 
i'll fix it.
> > Tools/EWebLauncher/main.c:565
> > +    Evas_Event_Key_Up *ev = (Evas_Event_Key_Up*) event_info;
> 
> (Evas_Event_Key_Up*) ?
do you point to type casting, *'s position or Evas_Event_Key_Up itself?
Eweblauncher is still C file.

[JungJik Lee]

Created attachment 126077 [details]
patch_1

[KwangHyuk]

LGTM.

[Chang Shu]

Comment on attachment 126077 [details]
patch_1

View in context: https://bugs.webkit.org/attachment.cgi?id=126077&action=review

> Tools/EWebLauncher/main.c:436
> +    if (!strcmp(ev->key, "Control_L"))
> +        modifierKey |= ECORE_EVENT_MODIFIER_CTRL;

Why isn't this a part of the if-elseif block below?
In another question, a key event usually comes in with modifier status. That is to say, when you have ev->key=="g", you check if ev->modifier==CTRL-L(note this is my fake code). Isn't it the case in EFL? Using a static modiferkey variable seems hacky.

[JungJik Lee]

Created attachment 127733 [details]
patch_2

Thanks your comment and as your comment, I found the simple way to use modifier key.

[Chang Shu]

Comment on attachment 127733 [details]
patch_2

Good!

[WebKit Review Bot]

Comment on attachment 127733 [details]
patch_2

Clearing flags on attachment: 127733

Committed r108192: <http://trac.webkit.org/changeset/108192>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.