Bug 77929

Summary: Stop calling Element::ensureShadowRoot() if it's used in construction phase.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: morrita, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 77965, 78094    
Bug Blocks: 77608    
Description Flags
Patch none

Description Shinya Kawanaka 2012-02-06 20:29:38 PST
Some elements calls ensureShadowRoot() dynamically, but the other elements calls ensureShadowRoot() when they are constructing.
These calls can be easily removed, so let's remove them first.
Comment 1 Shinya Kawanaka 2012-02-06 21:11:03 PST
Created attachment 125761 [details]
Comment 2 Hajime Morrita 2012-02-06 21:35:36 PST
Comment on attachment 125761 [details]

Basically OK. Could you split symbol removal to another patch?
Comment 3 Shinya Kawanaka 2012-02-06 21:42:35 PST
Created attachment 125763 [details]
Comment 4 WebKit Review Bot 2012-02-06 23:25:21 PST
Comment on attachment 125763 [details]

Clearing flags on attachment: 125763

Committed r106909: <http://trac.webkit.org/changeset/106909>
Comment 5 WebKit Review Bot 2012-02-06 23:25:26 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Shinya Kawanaka 2012-02-07 18:18:01 PST
rolled out, so reopen.
Comment 7 Shinya Kawanaka 2012-02-07 23:14:19 PST
Created attachment 126014 [details]
Comment 8 Shinya Kawanaka 2012-02-07 23:16:38 PST
We're not sure that patch caused chromium win release bot failure. I guess this patch doesn't, but I'm not sure. The previous export list patch caused it, maybe?

So let's land it again and see the chromium bot again.
Comment 9 WebKit Review Bot 2012-02-07 23:29:29 PST
Comment on attachment 126014 [details]

Rejecting attachment 126014 [details] from commit-queue.

shinyak@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 10 Hajime Morrita 2012-02-08 00:21:18 PST
Comment on attachment 126014 [details]

Let's see what happen...
Comment 11 WebKit Review Bot 2012-02-08 00:57:24 PST
Comment on attachment 126014 [details]

Clearing flags on attachment: 126014

Committed r107050: <http://trac.webkit.org/changeset/107050>
Comment 12 WebKit Review Bot 2012-02-08 00:57:29 PST
All reviewed patches have been landed.  Closing bug.
Comment 13 Shinya Kawanaka 2012-02-08 18:21:14 PST
I found a bug that ShadowRoot checks ExceptionCode, but it was not initialized.
We shouldn't assume ExceptionCode is initialized...
Comment 14 Shinya Kawanaka 2012-02-08 18:24:27 PST
rolled out again, reopen.
Comment 15 Shinya Kawanaka 2012-02-08 18:47:42 PST
Created attachment 126216 [details]
Comment 16 Hajime Morrita 2012-02-08 21:47:07 PST
Comment on attachment 126216 [details]

Clearing flags on attachment: 126216

Committed r107178: <http://trac.webkit.org/changeset/107178>
Comment 17 Hajime Morrita 2012-02-08 21:47:17 PST
All reviewed patches have been landed.  Closing bug.
Comment 18 Shinya Kawanaka 2012-02-08 21:54:56 PST
Let's seeing http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29?numbuilds=50 for a while.
Comment 19 Shinya Kawanaka 2012-02-08 22:17:31 PST

OK. webkit-unit-tests passed.