Summary: | Dashboard on perf-o-matic should be sorted | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | WebKit Website | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, morrita | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2012-02-06 18:36:50 PST
Created attachment 125750 [details]
Fixes the bug
Comment on attachment 125750 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=125750&action=review > Websites/webkit-perf.appspot.com/js/config.js:84 > + for (test in testToId) > + tests.push(test); Can you use Object.keys(testToId)? > Websites/webkit-perf.appspot.com/js/config.js:88 > + for (var i = 0; i < tests.length; i++) > + sortedTestToId[tests[i]] = testToId[tests[i]]; > + dashboardManifest['testToId'] = sortedTestToId; This is OK, but it would be more efficient to sort when you use dashboardManifest['testToId']. I guess that involves changing perfomatic code. Comment on attachment 125750 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=125750&action=review >> Websites/webkit-perf.appspot.com/js/config.js:84 >> + tests.push(test); > > Can you use Object.keys(testToId)? Sure. >> Websites/webkit-perf.appspot.com/js/config.js:88 >> + dashboardManifest['testToId'] = sortedTestToId; > > This is OK, but it would be more efficient to sort when you use dashboardManifest['testToId']. I guess that involves changing perfomatic code. Right. And we can't sort tests on Mozilla's version (the order is hard-coded there). Fixed in http://trac.webkit.org/changeset/106960. |