Summary: | [CG] Remove old CG specific shadow setting code from canvas | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matthew Delaney <mdelaney7> | ||||||
Component: | Canvas | Assignee: | Matthew Delaney <mdelaney7> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cmarrin, mdelaney7, mitz | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Matthew Delaney
2012-02-06 16:24:08 PST
Created attachment 125734 [details]
Patch
Comment on attachment 125734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125734&action=review > Source/WebCore/ChangeLog:4 > + Removing old CG shadow code. This needs to be a bit more detailed. Why was the old code added? Why is it OK to remove it now? Created attachment 125868 [details]
Patch
Comment on attachment 125868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125868&action=review > Source/WebCore/ChangeLog:8 > + The CG specific shadow offset hack was added in http://trac.webkit.org/changeset/34317 > + but has since moved down into GraphicsContextCG::setLegacyShadow that is called > + by applyShadow() thus the shadow hack is redundant here if we call applyShadow() It's very hard to parse this run-on sentence. > Source/WebCore/ChangeLog:12 > + The CG specific shadow setting block of code is redundant since any setting we > + do here to the CGContext will get overwritten later by any subsequent shadow setting > + or unsetting since the values in the State object are what's push down into CG. And this one. Committed r106988: <http://trac.webkit.org/changeset/106988> |