http/tests/security/xssAuditor/cookie-injection.html is flaky

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Barth]

http/tests/security/xssAuditor/cookie-injection.html is flaky

[Adam Barth]

Created attachment 125717 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 125717 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125717&action=review

The change looks fine now that I understand it.

> LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl:51
> +    print "<script>if (/testcookie/.exec(document.cookie)) { alert('FAIL: ' + document.cookie); document.cookie = 'testcookie=remove; max-age=-1'; }</script>\n";

I think you want .test() instead of .exec(): https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/RegExp/test

> LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl:52
>  }

I think we should also alert PASS to make it clearer that it passed.

[Adam Barth]

Created attachment 125729 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 125729 [details]
Patch for landing

Rejecting attachment 125729 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10594 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 10594.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11436116

[Adam Barth]

Committed r106906: <http://trac.webkit.org/changeset/106906>