| Summary: | Change baselinePosition and lineHeight to LayoutUnit | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||
| Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, eric, leviw, rakuco, tkent, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 60318 | ||||||||
| Attachments: |
|
||||||||
|
Description
Emil A Eklund
2012-02-06 15:07:43 PST
Created attachment 125720 [details]
Patch
Comment on attachment 125720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125720&action=review > Source/WebCore/ChangeLog:9 > + Change the virtual baselinePosition and lineHeight methods to use > + LayoutUnits in preparation for the switch over to subpixel layout. It would be better to explain why these functions should be using these types in the Changelog. You don't have to detail each one, but a setence like: RenderTheme deals only with rendering objects, which will be positioned by LayoutUnit coordinates. or something like that. > It would be better to explain why these functions should be using these types in the Changelog.
Good point, I'll update the description to be more descriptive.
Created attachment 125745 [details]
Patch
Thanks! Comment on attachment 125745 [details] Patch Clearing flags on attachment: 125745 Committed r106900: <http://trac.webkit.org/changeset/106900> All reviewed patches have been landed. Closing bug. |