Bug 77897

Summary: [Chromium] SkDevice caching by per-tile texture updater.
Product: WebKit Reporter: David Reveman <reveman>
Component: WebCore Misc.Assignee: David Reveman <reveman>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: danakj
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 75715    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

David Reveman
Reported 2012-02-06 13:15:34 PST
Avoid to create a new SkDevice after each update. This is efficient with the per-tile texture updater as update size is very often the same. Provides a performance improvement at the cost of higher memory usage.
Attachments
Patch (1.52 KB, patch)
2012-02-06 13:18 PST, David Reveman 		no flags
DetailsFormatted DiffDiff
Patch (9.10 KB, patch)
2012-02-09 11:27 PST, David Reveman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Reveman
Comment 1 2012-02-06 13:18:14 PST
Created attachment 125700 [details] Patch
Dana Jansens
Comment 2 2012-02-09 10:21:59 PST
Comment on attachment 125700 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125700&action=review > Source/WebCore/platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:-48 > - m_device = adoptPtr(new SkDevice(SkBitmap::kARGB_8888_Config, sourceRect.width(), sourceRect.height())); for posterity: always be the size of the texture and less resizing will be required.
David Reveman
Comment 3 2012-02-09 11:27:01 PST
Created attachment 126336 [details] Patch
David Reveman
Comment 4 2012-02-11 15:23:55 PST
*** This bug has been marked as a duplicate of bug 78426 ***
Note You need to log in before you can comment on or make changes to this bug.