Bug 77891

Summary:

Correct usage of LayoutUnits in dom, editing, page, accessibility, inspector, and loader

Product:

WebKit

Reporter:

Levi Weintraub <leviw>

Component:

Layout and Rendering

Assignee:

Levi Weintraub <leviw>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eae, eric, japhet, macpherson, menard, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

77920

Bug Blocks:

60318

Attachments:

Description	Flags
Patch	none

Description Levi Weintraub 2012-02-06 11:56:34 PST

As we worked the bugs out of our sub-pixel positioning change on our branch, some usages of Layout* types were added, while others went back to integers. This brings trunk's usage in line with our branch.

Comment 1 Levi Weintraub 2012-02-06 12:00:56 PST

Created attachment 125682 [details]
Patch

Comment 2 Eric Seidel (no email) 2012-02-06 13:10:44 PST

Do we have a document somewhere which describes the general usage guidelines for types in WebCore?  I want to know (at a high level) where we plan to use LayoutUnit vs. int vs. float vs. double vs. whatever.

Comment 3 Levi Weintraub 2012-02-06 14:19:01 PST

(In reply to comment #2)
> Do we have a document somewhere which describes the general usage guidelines for types in WebCore?  I want to know (at a high level) where we plan to use LayoutUnit vs. int vs. float vs. double vs. whatever.

Feel free to ask for clarification and well add it to this doc: https://trac.webkit.org/wiki/LayoutUnit

Comment 4 Levi Weintraub 2012-02-06 15:55:36 PST

Comment on attachment 125682 [details]
Patch

Thanks for the review!

Comment 5 WebKit Review Bot 2012-02-06 17:36:41 PST

Comment on attachment 125682 [details]
Patch

Clearing flags on attachment: 125682

Committed r106884: <http://trac.webkit.org/changeset/106884>

Comment 6 WebKit Review Bot 2012-02-06 17:36:47 PST

All reviewed patches have been landed.  Closing bug.