Summary: | Web Inspector: don't mark object is queriable if it is only reachable by internal reference | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Yury Semikhatsky
2012-02-06 08:29:10 PST
Created attachment 125655 [details]
Patch
Comment on attachment 125655 [details]
Patch
looks good to me
Comment on attachment 125655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125655&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:-1127 > - if (this._flags[node.nodeIndex] & flag) > - continue; this is necessary check. please revert this. Created attachment 125656 [details]
Patch
Comment on attachment 125656 [details]
Patch
looks good to me
Comment on attachment 125656 [details] Patch Attachment 125656 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11430457 New failing tests: inspector/profiler/heap-snapshot.html Committed r106928: <http://trac.webkit.org/changeset/106928> |