Bug 77877

Summary: Web Inspector: don't mark object is queriable if it is only reachable by internal reference
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+, webkit.review.bot: commit-queue-

Description Yury Semikhatsky 2012-02-06 08:29:10 PST
Web Inspector: don't mark object is queriable if it is only reachable by internal reference
Comment 1 Yury Semikhatsky 2012-02-06 08:32:09 PST
Created attachment 125655 [details]
Patch
Comment 2 Mikhail Naganov 2012-02-06 08:35:20 PST
Comment on attachment 125655 [details]
Patch

looks good to me
Comment 3 Ilya Tikhonovsky 2012-02-06 08:41:15 PST
Comment on attachment 125655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125655&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:-1127
> -            if (this._flags[node.nodeIndex] & flag)
> -                continue;

this is necessary check. please revert this.
Comment 4 Yury Semikhatsky 2012-02-06 08:41:29 PST
Created attachment 125656 [details]
Patch
Comment 5 Ilya Tikhonovsky 2012-02-06 08:42:48 PST
Comment on attachment 125656 [details]
Patch

looks good to me
Comment 6 WebKit Review Bot 2012-02-06 09:11:59 PST
Comment on attachment 125656 [details]
Patch

Attachment 125656 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11430457

New failing tests:
inspector/profiler/heap-snapshot.html
Comment 7 Yury Semikhatsky 2012-02-07 04:53:12 PST
Committed r106928: <http://trac.webkit.org/changeset/106928>