Bug 77866

Summary:

[webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, levin, ojan, pnormand, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mrobinson: review+, mrobinson: commit-queue-

Description Philippe Normand 2012-02-06 05:21:28 PST

These files define GObjects, which implies some definitions of variables and functions containing underscores.

Comment 1 Philippe Normand 2012-02-06 05:29:08 PST

Created attachment 125624 [details]
Patch

Comment 2 WebKit Review Bot 2012-02-06 05:30:28 PST

Attachment 125624 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1

Tools/Scripts/webkitpy/style/checker.py:215:  missing whitespace after ','  [pep8/E231] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Martin Robinson 2012-02-06 09:10:02 PST

Comment on attachment 125624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125624&action=review

>> Tools/Scripts/webkitpy/style/checker.py:215
>> +     ["-readability/naming",]),
> 
> missing whitespace after ','  [pep8/E231] [5]

I think you can just remove the interior comma to make the style bot happy.

Comment 4 Philippe Normand 2012-02-06 09:35:52 PST

Committed r106814: <http://trac.webkit.org/changeset/106814>