Bug 77861

Summary: HasIDFlag and HasClassFlag can be removed.
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 78070    
Bug Blocks: 77860    
Attachments:
Description Flags
Patch kling: review+, morrita: commit-queue-

Hajime Morrita
Reported 2012-02-06 02:20:05 PST
Node::HasIDFlag and Node::HasClassFlag can be replaced with ElementAttributeData, which doesn't need any hashtable lookup.
Attachments
Patch (8.59 KB, patch)
2012-02-08 17:50 PST, Hajime Morrita 		kling: review+
morrita: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-02-08 17:50:13 PST
Created attachment 126208 [details] Patch
Hajime Morrita
Comment 2 2012-02-08 17:51:45 PST
Ryosuke, Andreas, could you take a look? Note that I don't see any significant performance impact on Dromaeo.
Andreas Kling
Comment 3 2012-02-08 17:56:33 PST
Comment on attachment 126208 [details] Patch Great idea! r=me
Hajime Morrita
Comment 4 2012-02-08 18:01:10 PST
Waiting Bug 78070 is resolved as rniwa's suggestion at irc.
Hajime Morrita
Comment 5 2012-02-21 23:21:23 PST
Committed r108449: <http://trac.webkit.org/changeset/108449>
Note You need to log in before you can comment on or make changes to this bug.