Bug 77850

Summary: Web Inspector: get rid of artificial heap snapshot nodes from the retaining tree.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 78411    
Attachments:
Description Flags
Patch
none
Patch none

Ilya Tikhonovsky
Reported 2012-02-05 22:06:44 PST
%subj%
Attachments
Patch (4.73 KB, patch)
2012-02-05 22:11 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (4.73 KB, patch)
2012-02-05 23:26 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-02-05 22:11:10 PST
Created attachment 125572 [details] Patch
Yury Semikhatsky
Comment 2 2012-02-05 23:18:03 PST
Comment on attachment 125572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125572&action=review > Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:399 > + " && (" + !this.showRetainingEdges + " || (!edge.node.id !== 1 && !edge.node.isArtificial))\n" + !edge.node.id !== 1 will always evaluate to true, r- for this.
Ilya Tikhonovsky
Comment 3 2012-02-05 23:26:06 PST
Created attachment 125580 [details] Patch
Ilya Tikhonovsky
Comment 4 2012-02-05 23:53:15 PST
Comment on attachment 125580 [details] Patch Clearing flags on attachment: 125580 Committed r106778: <http://trac.webkit.org/changeset/106778>
Ilya Tikhonovsky
Comment 5 2012-02-05 23:53:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.